Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Dependencies: Store reflected members instead of creating new ones in tests. #17

Conversation

costdev
Copy link

@costdev costdev commented Feb 5, 2024

Previously, each call to the get|set_property_value() and call_method() methods would create a new ReflectionProperty or ReflectionMethod respectively.

This PR stores the created ReflectionProperty and ReflectionMethod instances to reduce load during the tests.

The $reflected_members property is emptied after all Plugin Dependencies tests run.

Copy link

github-actions bot commented Feb 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @me@colin-stewart.co.uk.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: .

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: me@colin-stewart.co.uk.


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@afragen afragen merged commit 51a1be6 into afragen:dependencies-tab Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants